pythonPackages.pywinrm: old rev -> 0.1.1 #15813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously tied to an older commit rev and not an actual release version; and that old commit was causing connectivity issues due to improper SSL support.
joachifm
added
6.topic: python
8.has: package (update)
|
@elasticdog the failure only occurs with Python 3.5 and during checkPhase and is a common issue (#14849). Setuptools tries to run tests, and is a bit too eager with it with Python 3.5 and starts loading stuff it shouldn't. What needs to be done is disabling testing (and adding a note that no tests are in the archive). I will merge this anyway since the update is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This was previously tied to an older commit rev and not an actual release version; and that old commit was causing connectivity issues due to improper SSL support. That is fixed in the 0.1.1 release.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Note that I did test with
nox-review wip, but get the following error:...but the Kerberos support is optional, and I wasn't sure how to have it completely ignored. Outside of nox-review, everything works as expected connecting to Windows hosts without Kerberos. Any suggestions on how that optional dep should be handled better?